Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(elevation): Simplify README to follow proposed best practices #826

Merged
merged 8 commits into from
Jun 23, 2017

Conversation

lynnmercier
Copy link
Contributor

No description provided.

@lynnmercier lynnmercier requested a review from amsheehan June 14, 2017 15:23
@codecov-io
Copy link

codecov-io commented Jun 14, 2017

Codecov Report

Merging #826 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files          69       69           
  Lines        3181     3181           
  Branches      387      387           
=======================================
  Hits         3148     3148           
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01decc3...1b5026a. Read the comment docs.

Copy link
Contributor

@amsheehan amsheehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this, just remove that "s" and we're good to go!

🥇

If you need more configurability over your transitions, you can easily accomplish this by using
the `mdc-elevation-transition-rule` function in conjunctions with the exported sass variables that
mdc-elevation exposes for purposes of transitioning.
If you need more configurability over your transitions, use the `mdc-elevation-transition-rule` function in conjunctions with the exported sass variables.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the "s" from "conjunction"

@lynnmercier lynnmercier merged commit 82cd7b6 into master Jun 23, 2017
@lynnmercier lynnmercier deleted the docs/elevation branch July 12, 2017 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants